-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose fp-ts modules without lib/es6 prefix #1241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm extremely eager for this! Great work. |
@gcanti Is there something we can help to move this PR forward? |
@anilanar planned for v2.8 |
gcanti
pushed a commit
that referenced
this pull request
Aug 4, 2020
This was referenced Aug 7, 2020
This was referenced Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows importing
fp-ts
modules without specifing the/lib
or/es6
prefix:Build tools will automatically resolve the right path based on the current environment, pointing to
/lib
version for commonjs and/es6
version for ES6.For now the
/lib
andes6
paths are still available, so this feature is completely backward compatible.This should enhance the library ergonomics and tree-shakeability.
Note: in order to achieve this goal, the standard
npm publish
command was disabled in favour of annpm run release
command which builds the library and prepares the package for publication.ref #1227 #1053