Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check PVC cleanup pods for failure (events and status) #551

Closed
amisevsk opened this issue Aug 12, 2021 · 0 comments · Fixed by #846
Closed

Check PVC cleanup pods for failure (events and status) #551

amisevsk opened this issue Aug 12, 2021 · 0 comments · Fixed by #846
Milestone
v0.15.x

Comments

@amisevsk
Copy link
Collaborator

Description

Currently, when a workspace is deleted, a cleanup job runs to remove workspace-related files from the common PVC. This job can fail (if the pod fails above a threshold), but in some cases it can just hang indefinitely, if e.g. the pod cannot be scheduled, etc.

We should apply the same logic we use for checking workspace pods for failure to the PVC cleanup job that runs on DevWorkspace deletion. If a PVC cleanup job fails, the workspace should be treated in the same way as when the PVC cleanup job fails.
@ibuziuk ibuziuk mentioned this issue May 18, 2022
Closed
49 tasks
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue May 18, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
ecf9929 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue May 18, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
22fab3c 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue May 26, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
5058883 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue May 30, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
ec644bd 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue May 30, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
64b2bec 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
@AObuchow AObuchow mentioned this issue May 30, 2022
Merged
3 tasks
@ibuziuk ibuziuk mentioned this issue Jun 8, 2022
Closed
64 tasks
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Jun 14, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
32f04ca 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Jun 16, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
4194c31 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Jun 17, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
9c13ba4 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit that referenced this issue Jun 21, 2022
@AObuchow
feat: report error when common PVC cleanup job hangs
f3e317a 
Fix #551

Signed-off-by: Andrew Obuchowicz <[email protected]>
amisevsk pushed a commit to amisevsk/devworkspace-operator that referenced this issue Jul 4, 2022
@AObuchow @amisevsk
feat: report error when common PVC cleanup job hangs
92994a7 
Fix devfile#551

Signed-off-by: Andrew Obuchowicz <[email protected]>
(cherry picked from commit f3e317a)
@amisevsk amisevsk mentioned this issue Jul 4, 2022
Merged
3 tasks
ibuziuk pushed a commit that referenced this issue Jul 5, 2022
@AObuchow @ibuziuk
feat: report error when common PVC cleanup job hangs
e62737e 
Fix #551

Signed-off-by: Andrew Obuchowicz <[email protected]>
(cherry picked from commit f3e317a)
@amisevsk amisevsk added this to the v0.15.x milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.x
Development

Successfully merging a pull request may close this issue.

Report error when common PVC cleanup job hangs AObuchow/devworkspace-operator
1 participant
@amisevsk