Reapply reverted changes from PR #954

[amisevsk]

What does this PR do?

Reapply changes from PR #954 (commits ac944d5..25d533b) that had been reverted (PR #972)

The original PR was reverted due to required changes in the Che Operator. As those are now applied, the original PR can be re-applied.

I.e. revert the revert: #972

What issues does this PR fix or reference?

N/A

Is it tested? How?

Changes are same as #954

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[codecov]

Codecov Report

Base: 50.20% // Head: 54.04% // Increases project coverage by +3.84% 🎉

Coverage data is based on head (e7130c9) compared to base (890b27c).
Patch coverage: 87.94% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   50.20%   54.04%   +3.84%     
==========================================
  Files          39       44       +5     
  Lines        2484     2766     +282     
==========================================
+ Hits         1247     1495     +248     
- Misses       1107     1135      +28     
- Partials      130      136       +6     

Impacted Files	Coverage Δ
pkg/provision/workspace/rbac/common.go	68.75% <68.75%> (ø)
pkg/provision/workspace/rbac/migrate.go	82.97% <82.97%> (ø)
pkg/provision/workspace/rbac/finalize.go	85.71% <85.71%> (ø)
pkg/provision/workspace/rbac/rolebinding.go	88.88% <88.88%> (ø)
pkg/provision/workspace/rbac/role.go	95.12% <95.12%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amisevsk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment