Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the public-upload-to-imgur action #398

Merged
merged 4 commits into from
Dec 28, 2020
Merged

Add the public-upload-to-imgur action #398

merged 4 commits into from
Dec 28, 2020

Conversation

Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Dec 19, 2020

Hello there,

This PR should allow us to upload images to the GitHub comments using GitHub Actions. You can see an example in the message below.

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 19, 2020
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 19, 2020
@github-actions
Copy link
Contributor

Hi! I'm Devicons' Peek Bot!
I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:
Peeked Icons (top left)
Note: If the image doesn't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.
Here is the url.

The maintainers will now take a look at it and decide whether to merge your PR.
Cheers :),
Peek Bot

@Thomas-Boi Thomas-Boi changed the title Add the public-upload-to-imgur action (testing, don't merge) Add the public-upload-to-imgur action Dec 19, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool! I love it! Amazing work! 👍🏻
I was thinking about: Maybe we should create the action-repository under the domain of "devicon". We could fork your repo Thomas-Boi/public-upload-to-imgur so it will remain credit to your work but we have it in the scope of this project. Happy to hear your thoughs about it.

@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Dec 20, 2020

Hey amacado,

I think that's a good idea. Can you add me into the devicons organization please? I can fork my repo and upload it there. I'm also planning adding more documentations and publish it as well.

@amacado
Copy link
Member

amacado commented Dec 26, 2020

Think that's a good idea. Can you add me into the devicons organization please? I can fork my repo and upload it there. I'm also planning adding more documentations and publish it as well.

Sorry, did not get notified about your edit and did not see that you weren't added to the orga yet. Sorry for the delay, you have a invitation.

@amacado
Copy link
Member

amacado commented Dec 26, 2020

Think that's a good idea. Can you add me into the devicons organization please? I can fork my repo and upload it there. I'm also planning adding more documentations and publish it as well.

Sorry, did not get notified about your edit and did not see that you weren't added to the orga yet. Sorry for the delay, you have a invitation.

@Thomas-Boi
Copy link
Member Author

Hey @amacado,

Thank you for the invite. However, it seems that I don't have the permission to create public repos in the devicon organization 😅. Can you give me permission to do this please?

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 28, 2020
@github-actions
Copy link
Contributor

Hi!

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

Peeked Icons (top left)

Note: If the image doesn't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Cheers :),

Peek Bot

@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Dec 28, 2020

Hey @amacado,

Everything should be good for this PR. I've updated the new action and everything seems to work fine. Note that the multiple file input/glob has not been tested. I'll keep working on it since I'm planning to add more screenshots to the peek script plus make it a bit faster. That'll be another PR though, for now we can merge this one in (unless I can finish it before you accept the PR)

@amacado amacado merged commit 3544e15 into develop Dec 28, 2020
@amacado amacado deleted the TB_actionTest branch December 28, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants