-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the public-upload-to-imgur action #398
Conversation
Hi! I'm Devicons' Peek Bot! The maintainers will now take a look at it and decide whether to merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so cool! I love it! Amazing work! 👍🏻
I was thinking about: Maybe we should create the action-repository under the domain of "devicon". We could fork your repo Thomas-Boi/public-upload-to-imgur
so it will remain credit to your work but we have it in the scope of this project. Happy to hear your thoughs about it.
Hey amacado, I think that's a good idea. Can you add me into the devicons organization please? I can fork my repo and upload it there. I'm also planning adding more documentations and publish it as well. |
Think that's a good idea. Can you add me into the devicons organization please? I can fork my repo and upload it there. I'm also planning adding more documentations and publish it as well. Sorry, did not get notified about your edit and did not see that you weren't added to the orga yet. Sorry for the delay, you have a invitation. |
Sorry, did not get notified about your edit and did not see that you weren't added to the orga yet. Sorry for the delay, you have a invitation. |
Hey @amacado, Thank you for the invite. However, it seems that I don't have the permission to create public repos in the devicon organization 😅. Can you give me permission to do this please? |
Hi! I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Note: If the image doesn't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Cheers :), Peek Bot |
299daa7
to
4ec9d85
Compare
Hey @amacado, Everything should be good for this PR. I've updated the new action and everything seems to work fine. Note that the multiple file input/glob has not been tested. I'll keep working on it since I'm planning to add more screenshots to the peek script plus make it a bit faster. That'll be another PR though, for now we can merge this one in (unless I can finish it before you accept the PR) |
Hello there,
This PR should allow us to upload images to the GitHub comments using GitHub Actions. You can see an example in the message below.