wuhbtool: Allow a boot sound to be provided in btsnd format. Fixes #12 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to wuhbtool only to allow a custom file to be passed as a boot sound.
In order to work with the streamlined cmake targets provided by wut tools and use the env variable format, some dependant changes would be required in the wut repo.
https://github.com/devkitPro/wut/blob/958936de47c8765a770eeaee6d10e460cc02c28e/share/wut_rules#L55-L59
However, i'm unfamiliar with the toolchain and not sure how deep it goes.
Doesn't convert from wav, and no validation at this point.
Only example i can see in the wild of converting to the required format is this repo (working)
However, even it does not convert it into 16-bit 48Khz wav format required, so plenty to do to bring that into the toolchain, but its beyond my level of C.
Appreciate any feedback but more complex work will likely need help from others.
May be useful to note that current implementation of aroma homebrew_on_menu plugin limits the boot sound to only titles that have also provided a Tv and DRC splash image.
https://github.com/wiiu-env/homebrew_on_menu_plugin/blob/main/src/main.cpp#L565-L571