Update update-spec.d.ts, resolve #2001 #2049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmarques
changed the title
|
@dfahlander wanted to make sure you saw this. Take your time of course. |
|
Seems to be a typo in the commit. Remove equals sign between interface and leading bracket?
|
|
Yes you are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The issue #2001 can be resolved with this change.
I have tested this by messing with the
node_modules\.pnpm\[email protected]\node_modules\dexie\dist\dexie.d.tsfile in my node_modules, resolving the typescript error.Also the test suite ( E:\git\Dexie.js>pnpm test ) is all green.
Using typescript 5.5.4, and dexie 4.0.8.