-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for macCatalyst and visionOS. Drop earlier version support. #81
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 98.92% 99.02% +0.10%
==========================================
Files 13 11 -2
Lines 560 515 -45
==========================================
- Hits 554 510 -44
+ Misses 6 5 -1 |
acb7d5f
to
c759642
Compare
Ah shucks. Adding Linux supports requires re-implementing |
This reverts commit dee7907.
* watchOS 5 or later. | ||
* macOS 10.14 or later. | ||
* Swift 5.0 or later. | ||
* Xcode 12.4 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm somewhat tempted to go straight to Swift 5.9 and ignore older Xcode versions, but continuing to support older Xcode versions enables a test suite across more Apple platform versions, and currently there are zero code changes required to support Swift/Xcode versions above Swift 5.5.
@@ -0,0 +1,48 @@ | |||
// swift-tools-version:5.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these files are just clones of the Package.swift
with different swift tools versions unless otherwise specified.
.watchOS(.v6), | ||
.macOS(.v10_15), | ||
.macCatalyst(.v13), | ||
.visionOS(.v1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visionOS
is new to the Swift 5.9 Package.swift file. We'll add CI for it once arm
Xcode 15.2 machines are available to OSS projects on GitHub.
We were supporting a very old list of Swift, Xcode, and Apple platform versions. This PR brings us into the more modern age, but still keeps a healthy list of supported platforms.