feat: HttpAgent uses anonymous identity to make syncTime call #969
+71
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can allow readState calls to work beyond 5 minutes
krpeacock
changed the title
size-limit report 📦
|
adamspofford-dfinity
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which can allow readState calls to work beyond 5 minutes
Description
Because we’ve added to the specification a feature that the check of the ingress_expiry is skipped for anonymous read_state requests (see spec), we can add this logic to the agent.
Fixes SDK-1953
How Has This Been Tested?
New e2e test against mainnet
Checklist: