Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perf: Introduce TypeKey instead of String keys for named types" #594

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jan 22, 2025

This is a breaking change.
I will create a next branch and merge this PR to it.

@lwshang lwshang requested a review from a team as a code owner January 22, 2025 20:58
Copy link

Name Max Mem (Kb) Encode Decode
blob 4_224 20_459_319 ($\textcolor{red}{0.00\%}$) 12_083_680 ($\textcolor{red}{0.02\%}$)
btreemap 75_456 4_022_699_521 ($\textcolor{red}{0.00\%}$) 15_670_422_014 ($\textcolor{red}{0.22\%}$)
nns 128 ($\textcolor{green}{-33.33\%}$) 2_257_486 ($\textcolor{red}{23.58\%}$) 5_494_177 ($\textcolor{red}{76.58\%}$)
nns_list_proposal 1_088 7_052_340 ($\textcolor{red}{4.96\%}$) 81_908_823 ($\textcolor{red}{36.04\%}$)
option_list 128 7_140_468 ($\textcolor{green}{-0.00\%}$) 25_769_889 ($\textcolor{red}{5.11\%}$)
text 6_336 20_455_442 ($\textcolor{green}{-0.00\%}$) 17_839_559 ($\textcolor{green}{-0.00\%}$)
variant_list 128 7_142_320 ($\textcolor{red}{0.01\%}$) 24_446_609 ($\textcolor{red}{4.50\%}$)
vec_int16 16_704 168_582_443 ($\textcolor{green}{-0.00\%}$) 1_073_765_826 ($\textcolor{red}{6.67\%}$)
  • Parser cost: 18_787_299 ($\textcolor{red}{4.05\%}$)
  • Extra args: 3_240_108 ($\textcolor{red}{38.01\%}$)
Click to see raw report

---------------------------------------------------

Benchmark: blob
  total:
    instructions: 32.55 M (0.01%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 20.46 M (0.00%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 12.08 M (0.02%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: text
  total:
    instructions: 38.30 M (-0.00%) (change within noise threshold)
    heap_increase: 99 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 20.46 M (-0.00%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 17.84 M (-0.00%) (change within noise threshold)
    heap_increase: 33 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: vec_int16
  total:
    instructions: 1.24 B (regressed by 5.71%)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 168.58 M (-0.00%) (change within noise threshold)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 1.07 B (regressed by 6.67%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: btreemap
  total:
    instructions: 19.69 B (0.18%) (change within noise threshold)
    heap_increase: 1179 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 4.02 B (0.00%) (change within noise threshold)
    heap_increase: 159 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 15.67 B (0.22%) (change within noise threshold)
    heap_increase: 1020 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: option_list
  total:
    instructions: 32.91 M (regressed by 3.96%)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.14 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 25.77 M (regressed by 5.11%)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: variant_list
  total:
    instructions: 31.59 M (regressed by 3.45%)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.14 M (0.01%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 24.45 M (regressed by 4.50%)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns
  total:
    instructions: 27.38 M (regressed by 14.95%)
    heap_increase: 2 pages (improved by 33.33%)
    stable_memory_increase: 0 pages (no change)

  0. Parsing (scope):
    instructions: 18.79 M (regressed by 4.05%)
    heap_increase: 2 pages (improved by 33.33%)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 2.26 M (regressed by 23.58%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 5.49 M (regressed by 76.58%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns_list_proposal
  total:
    instructions: 88.96 M (regressed by 32.92%)
    heap_increase: 17 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.05 M (regressed by 4.96%)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 81.91 M (regressed by 36.04%)
    heap_increase: 14 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: extra_args
  total:
    instructions: 3.24 M (regressed by 38.01%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------
Successfully persisted results to canbench_results.yml

@lwshang lwshang merged commit 32a6a6b into master Jan 22, 2025
6 checks passed
@lwshang lwshang deleted the revert-590-frankdavid/typekey branch January 22, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants