feat: evm_rpc_types crate and Nat256
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d5f3993
rvanasa
approved these changes
Aug 23, 2024
THLO
reviewed
Aug 23, 2024
THLO
approved these changes
Aug 23, 2024
gregorydemay
added a commit
that referenced
this pull request
Aug 28, 2024
…ate (#261) Follow-up on #257 to move the types `GetLogsArgs` and `LogEntry` to the `evm_rpc_types` crate, so that the public API of `eth_get_logs` only uses types from that crate. Additionally, add the types `Hex`, `Hex20`, and `Hex32` as a transparent wrapper around a Candid type `text` to represent Ethereum hex strings (prefixed by `0x`) containing an unbounded, 20 or 32 bytes, respectively.
gregorydemay
added a commit
that referenced
this pull request
Aug 29, 2024
Follow-up on #257 to move the type `TransactionReceipt` to the `evm_rpc_types` crate, so that the public API of `eth_get_transaction_receipt` only uses types from that crate.
gregorydemay
added a commit
that referenced
this pull request
Sep 11, 2024
Follow-up on #257 to move the type `Block` to the `evm_rpc_types` crate, so that the public API of `eth_get_block_by_number` only uses types from that crate. --------- Co-authored-by: rvanasa <[email protected]>
gregorydemay
added a commit
that referenced
this pull request
Sep 13, 2024
) Follow-up on #257 to move the following types to the `evm_rpc_types` crate: 1. `EthMainnetService` 2. `EthSepoliaService` 3. `HttpHeader` 4. `L2MainnetService` 5. `RpcApi` 6. `RpcConfig` 7. `RpcService` 8. `RpcServices` so that the public API of all methods in `main.rs` only use types from that crate as arguments.
gregorydemay
added a commit
that referenced
this pull request
Sep 16, 2024
Follow-up on #257 to move the following types to the `evm_rpc_types` crate: 1. `HttpOutcallError` 2. `JsonRpcError` 3. `MultiRpcResult` 4. `ProviderError` 5. `RpcError`, 6. `RpcResult` 7. `ValidationError` so that the public API of all methods in `main.rs` only use types from that crate as return types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new crate
evm_rpc_typesthat will contain all Candid types necessary to interact with the EVM RPC canister. As a first step for #243 :Nat256as a wrapper around aNatthat is guaranteed to have the same encoding/decoding as aNat, while ensuring that it fits in aU256bits.eth_fee_historyso that the public API only uses types from the newevm_rpc_typescrate .