test: render with events utility refactoring #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
approved these changes
Dec 17, 2024
…at/render-with-events
dskloetd
approved these changes
Dec 17, 2024
Yes, kind of. We do it this way so we don’t have to migrate all components at once. It reduces the number of changes needed for the upgrade by solely adapting few tests.
Once this PR is merged and rebased into the Svelte v5 branch, only one TODO will remain. |
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Jan 28, 2025
# Motivation Using the `$on` callback for testing is deprecated in Svelte v5. To align with the changes made in Gix-components (see PR [#544](dfinity/gix-components#554)), we will adopt the `events` option of the `render` function. To facilitate the upgrade and minimize changes in the Svelte v5 PR, we have refactored the test to utilize a utility function. # Changes - Extend `render` utility to support events - Replace all occurences of the keywords `$on()` with the usage of the utilitity # Summarized ``` component.$on("something", something) // => render(Component, {events: {something}} ``` --------- Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Jan 28, 2025
# Motivation Using the `$on` callback for testing is deprecated in Svelte v5. To align with the changes made in Gix-components (see PR [#544](dfinity/gix-components#554)), we will adopt the `events` option of the `render` function. To facilitate the upgrade and minimize changes in the Svelte v5 PR, we have refactored the test to utilize a utility function. # Changes - Extend `render` utility to support events - Replace all occurences of the keywords `$on()` with the usage of the utilitity # Summarized ``` component.$on("something", something) // => render(Component, {events: {something}} ``` --------- Signed-off-by: David Dal Busco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using an
$oncallback for testing is deprecated in Svelte v5 (PR #548). Instead, we will now use theeventsoption ofrender, which itself will eventually be replaced by the library. To minimize changes in the Svelte v5 PR, we refactored the test to use a utility function that handles rendering and event binding.Changes
renderWithEventsutilitiy.