Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Feature wasm-opt #84

Merged
merged 5 commits into from
Jan 28, 2025
Merged

fix: Feature wasm-opt #84

merged 5 commits into from
Jan 28, 2025

Conversation

fxgst
Copy link
Contributor

@fxgst fxgst commented Jan 28, 2025 •
edited
Loading

With no default features, ic-wasm should be buildable (for the wasm32-unknown-unknown target, used in the motoko playground). Currently, the use of wasm_opt::Feature prevents a build without the wasm_opt feature enabled.

@fxgst fxgst marked this pull request as ready for review January 28, 2025 13:02
@fxgst fxgst requested a review from a team as a code owner January 28, 2025 13:02
@lwshang lwshang merged commit 4c52e75 into main Jan 28, 2025
4 checks passed
@lwshang lwshang deleted the elias/fixwasmoptfeature branch January 28, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxgst @lwshang