Don't refer to the client as the "DFINITY client" #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsgunnlsgunn
approved these changes
Oct 31, 2019
|
@lsgunnlsgunn please could you take another look and confirm that I'm using the correct capitalization? |
|
Looks like I may have been right the first time... |
knl
added a commit
that referenced
this pull request
Jul 7, 2020
Various fixes in the output, to make it more correct, and avoid spamming of GitHub histories. Should be faster, too. This release brings the following: Formatting: * Fix: Add an empty line after the title. Now GitHub Commits list looks better. * Fix: Remove preceeding space in the title * Output branch name used by niv, so that it is clear what is being tracked * Add a title prefix support via `title_prefix` option Being nice: * Reformat mentions in the changelog to reduce spamming of mentioned developers (now, @knl will not generate a GitHub notification when present in the changelog) * Add option to avoid GitHub backreferencing the PR. That is, when we have #123 in the changelog, it will be a correct link to the correct repository, however, the referenced PR/issue will not contain a reference, thus reducing the spamming. See knl/niv-updater-action#26 for more details. * Make the location of `sources.json` customizable Performance: * Replace the use of jo with jq, thus avoiding to install jo * Do not install hub CLI, as it is present in the default image. This should avoid installing hub, speeding up the start.
knl
added a commit
that referenced
this pull request
Jul 7, 2020
Various fixes in the output, to make it more correct, and avoid spamming of GitHub histories. Should be faster, too. This release brings the following: Formatting: * Fix: Add an empty line after the title. Now GitHub Commits list looks better. * Fix: Remove preceeding space in the title * Output branch name used by niv, so that it is clear what is being tracked * Add a title prefix support via `title_prefix` option Being nice: * Reformat mentions in the changelog to reduce spamming of mentioned developers (now, @knl will not generate a GitHub notification when present in the changelog) * Add option to avoid GitHub backreferencing the PR. That is, when we have #123 in the changelog, it will be a correct link to the correct repository, however, the referenced PR/issue will not contain a reference, thus reducing the spamming. See knl/niv-updater-action#26 for more details. * Make the location of `sources.json` customizable Performance: * Replace the use of jo with jq, thus avoiding to install jo * Do not install hub CLI, as it is present in the default image. This should avoid installing hub, speeding up the start.
knl
added a commit
that referenced
this pull request
Jul 7, 2020
Various fixes in the output, to make it more correct, and avoid spamming of GitHub histories. Should be faster, too. This release brings the following: Formatting: * Fix: Add an empty line after the title. Now GitHub Commits list looks better. * Fix: Remove preceeding space in the title * Output branch name used by niv, so that it is clear what is being tracked * Add a title prefix support via `title_prefix` option Being nice: * Reformat mentions in the changelog to reduce spamming of mentioned developers (now, @knl will not generate a GitHub notification when present in the changelog) * Add option to avoid GitHub backreferencing the PR. That is, when we have #123 in the changelog, it will be a correct link to the correct repository, however, the referenced PR/issue will not contain a reference, thus reducing the spamming. See knl/niv-updater-action#26 for more details. * Make the location of `sources.json` customizable Performance: * Replace the use of jo with jq, thus avoiding to install jo * Do not install hub CLI, as it is present in the default image. This should avoid installing hub, speeding up the start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.