Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertTo-CamelCase #3

Open
toenuff opened this issue Mar 21, 2014 · 5 comments
Open

ConvertTo-CamelCase #3

toenuff opened this issue Mar 21, 2014 · 5 comments

Comments

@toenuff
Copy link

toenuff commented Mar 21, 2014

There's a bug in ConvertTo-CamelCase where only the first cmdlet is properly converted. Other cmdlets in the string get converted, but they lose the hyphen.

Please no one fix this. I have coded the fix and will be giving a live demo of the pull request during Techstravaganza tomorrow.

@dfinke
Copy link
Owner

dfinke commented Mar 21, 2014

Cool. Looking forward to hearing how the demo goes. I'll merge the change after.

@toenuff
Copy link
Author

toenuff commented Mar 21, 2014

Well the demo went poorly for this part :P I just realized why. I showed off my fancy pester tests, but I forgot that the test might need the ISE to run :P

toenuff added a commit to toenuff/PSharp that referenced this issue Mar 21, 2014
… with strings that have multiple instances of cmdlet names
@dfinke
Copy link
Owner

dfinke commented Mar 21, 2014

Ouch, bummer.

Sounds like in need to add a $Host.Name guard.

@toenuff
Copy link
Author

toenuff commented Mar 21, 2014

Well, it's there now :) I have til the PS deep dive to fix my github demos - I'll just find something else to fix of yours (that doesn't require ISE) - should be easy - finding code of yours with bugs, that is :P

@dfinke
Copy link
Owner

dfinke commented Mar 21, 2014

Thanks for the pull request, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants