-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on Windows10(x64) #53
Comments
Would you mind sharing your spec file? |
Yes of course :)
And the whole code is here: [https://github.com/udacity/ud892/tree/master/Lesson%204] Thank you! |
So, I was going through the code given and noticed that your gulp task seems to be missing the That may be the source of the problem. Let me know if that helps! |
I went ahead and cloned the courses repository down and everything works fine after I think a good course of action to determine where the error might be coming from is to include this option in the task: |
@NinaNVY. I totally lead you astray. It's |
Well that's infuriating. That totally sucks, sorry that it hung for so long 😢 . Could you give me your system specs (OS, Node version, NPM version, and anything else you want to add)? I will try to set up a VM and see what I can do from there. |
Yes, of course, thank you! And I checked all possible (just my guess) permission issues here. No permission issues. But isn't it too much work to create new VM? Maybe it would be easier to use TeamViewer? |
I tried run the following command: after that it is simply hanging on and sleeping. And here is the output of running phantomjs with jasmine: Is it about process or Child Process ? I found this:
|
That's super interesting. Have you ever been able to run For example saving this as a tiny little JS file and running it: console.log('Loading a web page');
var page = require('webpage').create();
var url = 'http://phantomjs.org/';
page.open(url, function (status) {
//Page is loaded!
phantom.exit();
}); |
Well, that's actually good. Concerning for me, but it means that your |
Ok! So. I went ahead and forked that Lesson repository so that we help narrow down specific issues pertaining to that code base. You can go on over here and clone that repository. Head on over to the |
Yep! There may be version differences and many other things. If you feel ok with it, I would encourage you do run |
I don't know what will be cleared in npm cache, if not too much trouble could you tell me in short? I know you are busy I just need some time to google it (sorry I'm a newbie). |
Here is the definition from the
What that means is that when you run
|
Thank you for the explanation! 👍 |
I have the same problem on windows, that is , when i run the gulp task it hangs with the text "Running Jasmine with Phantom" could it be realated to this?
I tried replacing execFile with exec at at least in doesnt hang... will see if i get time to investigate further |
actually, still same behaviour with ´exec´ as with ´execFile´ |
@henrikrudstrom please look at the end - when I tried to run phantomjs with jasmine, it asks for process variable |
@dflynn15 Here is what the npm member ashleygwilliams answered:
Sorry, I'm a newbie and I need more time to understand what she wrote :( How can I install |
@NinaNVY, so first things first. Let's talk about the error when installing A quick way around that is to As for the warnings, that's just simply saying that there are dependencies that are "out of date." This is not necessarily a bad thing. Some modules depend on specific versions because the community as a whole doesn't follow semver very well. So on occasion you'll see modules explicitly depend on older versions. In this case there are dependecies that are looking for older versions of |
Oh, Daniel, thank you for your time and kind attention! :)
Did I install gulp globally if I ran Would you tell me please how can I install |
So here's a quick rundown on the install flags and what each means. _This is taken from the npm install takes 3 exclusive, optional flags which save or update the package version in your main package.json:
When using any of the above options to save dependencies to your package.json, there is an additional, optional flag:
The -g or --global argument will cause npm to install the package globally rather than locally. See npm-folders. All in all, when you did As for the version I think it would benefit you a lot to go through |
Thank you so much for the instant response. As you can see from the output this test is as simple as it could be |
I've been having a similar issue, going through the current process I think I've identified an issue, haven't had the time to check further before finishing for the day, but thought Id leave it here as a potential starting point if I don't get a chance to follow up. It looks like the handlebars is rendered with absolute paths to assets i.e. Its possible phantomjs handles this, and its a red herring on my part, but putting logging into |
@Nysosis if you modify the |
I tried that, but it still gave the same On 22 March 2016 at 16:56, Daniel Flynn [email protected] wrote:
|
Right, been doing some more fiddling around at home, and managed to get it running and outputting to the console as expected. What I've had to do to get it to work:
This works for me on a w7 box, no idea how it would affect *nix machines running the plugin. |
@dflynn15 @Nysosis I did your additions to the code. It prints out to to the SpecrRunner.html this information from extraSpec.js:
but doesn't log the same information to the |
Can you run this command in the folder: There's something else that I've noticed when working with that workshop repo (I presume that's the one you're using? I grabbed it from earlier messages in the issue), the runner doesn't like the space in the folder name 'Lesson 4'. If I try to run |
@Nysosis Thank you! |
@NinaNVY I started from the same course and then created test git repository and shared it in my bug report: https://github.com/alexkonkin/gulp-jasmine-phantom_bug.git repository does not contain any packages that means that you should install |
@NinaNVY p.s.: please consider the suggestions above only as ideas that would allow us |
@alexkonkin Thank you! |
Any updates on this bug? Please let me know if this would be acceptable for you. |
Right now I am slammed with my job so maintaining this has been put lower on my priority list right now. You can always submit a PR with a fix and I can help validate the *nix side of things. It's much easier for me if you submit a PR rather than waiting on me to write and test the fix you proposed here. |
@Nysosis I have a branch up here. Would you mind testing that on your Windows env? |
I had the same issue when going through that course (on Windows 10, x64). I also gave a try for that branch you proposed @dflynn15.
When I look closer and compare your changes with backup I made from my patched version, I found out that jasmine-runner.js was missing a patch @Nysosis suggested, something like this: I am not sure if this will work on linux/osx but after this change that branch works for windows. |
Hello, I found one potential issue, I was getting the same error as the original: On some debugging, I found that on this line it is trying to spawn phantomjs.cmd: https://github.com/dflynn15/gulp-jasmine-phantom/blob/master/index.js#L22 I have installed phantomjs version 2.1.1, but it doesn't come with phantomjs.cmd. There is only a .exe. Either way, you could just run it as "phantomjs" without extension and it would work. Changing that line got me passed the "ENOENT" problem, and onto another problem, but this should be fixed anyway. |
Once I took the fix from @Nysosis (#53 (comment)), plus my fix for phantomjs.cmd, it was then working for me. Windows 8 |
Please merge the commits from #66 that are shown in the comment because I too confirm that it is what allows all of this to work on Windows with that Udacity course. I ended up installing phantomjs globally, and removed spaces from the path to the project because the jasmine / phantomjs scripts were having trouble with that, but I think after adding the code to properly deal with Windows file paths, it should work with such things normally. |
Any idea when this fix will be put in a release? I see that it has been merged into the master branch, but no release has been made with these updates. In my opinion, this is a pretty major issue if the plugin doesn't work on Windows computers at all. |
@MNR1 I realize the concern. It has been in testing to make sure it does not break other OS through the change. Because there are other features that are being merged in as well I have opted to wait. If you need the change simply use the Github url for your For now, I just ask you please be patient with me as I deal with other job and life related issues. |
@dflynn15 Thank you very much for your quick response. We are trying to use this plugin in the build of our first release of software so I was curious about the status. Attempting to use the GitHub URL right now. UPDATE: UPDATE AGAIN: UPDATE AGAIN AGAIN: |
@MNR1 I am going to revert the change that looks for the |
@dflynn15 Thank you. I look forward to the revision. |
Thanks @gwynjudd , your solution fixed the problem on my PC (Win10 x64)! |
Hello, Working from Samsung Laptop, AMD A6-3420M APU with Radeon(tm) HD Graphics 1.5GHz, 64bit, Windows 7. Error messages: [17:01:21] 'tests' errored after 2.7 s package.json phantomjs 2.1.1 is installed in Program Files and is in PATH. |
OK. The npm installer does not yet install the most update version for me. After making edits to local node_modules version, it does indeed work. |
Hi all, Use gulp-jasmine package instead of gulp-jasmine-phantom !!! Additionally edit gulpfile.js ... var jasmine = require('gulp-jasmine') |
Hi,
I have PhantomJS installed globally. Phantomjs binary is available in the PATH and executable from the command line.
Here is my gulp task
I can not find logs and events.js:141 to see what's going wrong.
Running Jasmine with minijasminenode2 goes well when I delete the string
integration: true
from my gulp taskPlease, help
The text was updated successfully, but these errors were encountered: