Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass vendor files as helpers to node-jasmine. #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryanbraun
Copy link

We came across an issue where we needed to pass vendor files in above specfiles for node-jasmine. This change allows the option to be passed through.


For details on helpers, see:
http://jasmine.github.io/2.4/node.html#section-12

See also, about jasmine.loadConfig:
http://jasmine.github.io/2.4/node.html#section-Load_configuration_from_a_file_or_from_an_object.

@dflynn15
Copy link
Owner

This allows the change to work for Unit tests running against Jasmine's CLI, however the same scenario could exist for Integration tests run through Phantom as well.

Would you mind adding the following:

  • Handling the same scenario for integration tests run through PhantomJS
  • Updating the README to account for the changes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants