[audit] xml-rs → quick-xml #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xml-rsis not maintained anymore. It is apparently currently being transferred, but even if that happens (which is not a given),xml-rsstill appears to have a large backlog of unresolved issues. Looks like it's time to switch.I found two crates that are actively maintained and can do SAX parsing:
unsafe, lots of tests, lots of recent commits. Lots of dependencies as well, but fortunately all of them are optional exceptmemchr, which I guess is OK. The API is similar toxml-rs, so migration is mostly straightforward.unsafe. Unfortunately, the API doesn't group attributes together (the current geodata importer relies on that), and I don't want to make too invasive changes when switching.So,
quick-xmlit is (for now). By the way, it really lives up to its name: importing Serbia now takes 01:08 minutes on my laptop, while it used to take 02:51 minutes.