-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve diff for un--explain
ed assertion failure
#1211
Comments
Gabriella439
added a commit
that referenced
this issue
Aug 7, 2019
Fixes #1211 The original implementation of diffing two lists in #450 attempted to add a special case in the logic for when the list had no common elements. However, this led to a bug where the two lists would display different if they were both empty. lists would never render. This change fixes that by removing the special case. The new output for the linked example is: ``` Use "dhall --explain" for detailed errors Error: Assertion failed [ … , - 1 , … , + 55 ] 16│ assert : fibs 10 ≡ [ 0, 1, 2, 3, 5, 8, 13, 21, 34, 55 ] 17│ (stdin):16:16 ```
Gabriella439
added a commit
that referenced
this issue
Aug 7, 2019
Fixes #1211 The original implementation of diffing two lists in #450 attempted to add a special case in the logic for when the list had no common elements. However, this led to a bug where the two lists would display different if they were both empty. lists would never render. This change fixes that by removing the special case. The new output for the linked example is: ``` Use "dhall --explain" for detailed errors Error: Assertion failed [ … , - 1 , … , + 55 ] 16│ assert : fibs 10 ≡ [ 0, 1, 2, 3, 5, 8, 13, 21, 34, 55 ] 17│ (stdin):16:16 ```
Merged
Fix is up here: #1213 |
mergify bot
pushed a commit
that referenced
this issue
Aug 8, 2019
Fixes #1211 The original implementation of diffing two lists in #450 attempted to add a special case in the logic for when the list had no common elements. However, this led to a bug where the two lists would display different if they were both empty. lists would never render. This change fixes that by removing the special case. The new output for the linked example is: ``` Use "dhall --explain" for detailed errors Error: Assertion failed [ … , - 1 , … , + 55 ] 16│ assert : fibs 10 ≡ [ 0, 1, 2, 3, 5, 8, 13, 21, 34, 55 ] 17│ (stdin):16:16 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the code below,
dhall --file fibs.dhall
reportsOnly when I turn on
--explain
,dhall
shows me the not-so-large detailed diff:(Aside: Instead of reporting the error location as
(stdin):16:16
,dhall
should include the filenamefibs.dhall
.)fibs.dhall
:The text was updated successfully, but these errors were encountered: