Different with-http CPP check; fix remote imports in GHCJS #1330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted #1311 before studying
Import.hs
carefully enough, and my GHCJS build worked perfectly (with local imports, doh!) so I didn't notice.Since I removed the GHCJS dependency on http-client, the CPP check for
MIN_VERSION_http_client
no longer works. I noticed the existence of-DWITH_HTTP
in the tasty test suite and added that at the library level. (I think it's clearer too.)Also, fortunately,
Manager
is not actually needed in Import.hs, just the check forWITH_HTTP
.