Use unnamed Pi type argument #2640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the `FromDhall` and `ToDhall` instances both use unnamed arguments in their type signature. The value of this type is not used on type level so it is not necessary to bring it into scope here. On the value level this obviously is still necessary but that part is untouched regarding this commit.
felixspringernatuvion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
FromDhallandToDhallinstance ofFixdon't use the exact same definition of the type. Sure they are judgementally equal, but why not make them syntactically equal aswell?In particular the use of the named argument in the pi type
"Make"is not the same. I personally think the best solution is to remove the name of this function, becauseMakeis not used in the return type of the pi type anyways. This is what I'm doing in this commit.Alternatively you could also change the
"_"to"Make"here:dhall-haskell/dhall/src/Dhall/Marshal/Encode.hs
Line 537 in f48fda9
That way both types would include the name
Make.