Fix Natural/fold for GHCJS bindings
#985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dhall-lang/dhall-lang#579 `Natural/fold` was misbehaving on GHCJS due to the use of `Natural` arithmetic (for some reason). This is a problem I've seen and fixed before, but needed to be fixed again after the migration to the new `Dhall.Eval` normalization engine. The fix is easy: use `Integer` instead of `Natural` for the accumulator of the fold and the bug disappears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dhall-lang/dhall-lang#579
Natural/foldwas misbehaving on GHCJS due to the use ofNaturalarithmetic (for some reason). This is a problem I've seen and fixed
before, but needed to be fixed again after the migration to the new
Dhall.Evalnormalization engine.The fix is easy: use
Integerinstead ofNaturalfor the accumulatorof the fold and the bug disappears.