Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Day 06 #188

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Day 06 #188

merged 10 commits into from
Mar 8, 2024

Conversation

pradyumna100903
Copy link
Contributor

Day 06

dhruvabhat24
dhruvabhat24 requested changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@dhruvabhat24 dhruvabhat24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation is not enough. Kindly provide some more information on your approach

@dhruvabhat24 dhruvabhat24 added the help wanted Extra attention is needed label Mar 7, 2024
@pradyumna100903
Copy link
Contributor Author

Fixed all Conflicts and Added Day 07 Code too . Please Review

dhruvabhat24
dhruvabhat24 requested changes Mar 7, 2024
View reviewed changes
Copy link
Owner

@dhruvabhat24 dhruvabhat24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly provide the clear explanation for both problems else it will be marked as invalid.

pradyumna100903
pradyumna100903 commented Mar 7, 2024
View reviewed changes
Copy link
Contributor Author

@pradyumna100903 pradyumna100903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now is it Fine , Provided Clear approach for both codes.

@dhruvabhat24 dhruvabhat24 merged commit 48f430a into dhruvabhat24:main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvabhat24 dhruvabhat24 dhruvabhat24 approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyumna100903 @dhruvabhat24