Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: channel #47

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Feature: channel #47

merged 5 commits into from
Jul 30, 2024

Conversation

liss-h
Copy link
Contributor

@liss-h liss-h commented Jul 29, 2024

Resolve #28

@liss-h liss-h marked this pull request as draft July 29, 2024 09:29
@liss-h liss-h marked this pull request as ready for review July 29, 2024 11:50
@liss-h liss-h requested a review from bigerl July 29, 2024 13:43
bigerl
bigerl requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review. More tomorrow

tests/tests_channel.cpp Outdated Show resolved Hide resolved
include/dice/template-library/channel.hpp Show resolved Hide resolved
bigerl
bigerl approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now covering the actual code. Nice work! The code is super clean and the synchronization primitives all seem to be used correctly.

The one thing that might make sense to patch is using a vector as backend instead of a dequeue as pointed out in your code TOD comment.

include/dice/template-library/channel.hpp Outdated Show resolved Hide resolved
include/dice/template-library/channel.hpp Show resolved Hide resolved
include/dice/template-library/channel.hpp Show resolved Hide resolved
include/dice/template-library/channel.hpp Show resolved Hide resolved
include/dice/template-library/channel.hpp Outdated Show resolved Hide resolved
include/dice/template-library/channel.hpp Outdated Show resolved Hide resolved
@liss-h liss-h merged commit 2224686 into develop Jul 30, 2024
7 checks passed
@liss-h liss-h mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liss-h @bigerl