fix: conditional rendering #2983
Merged
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18bc508 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
diegomura
force-pushed
the
dm/fix-conditional-rendering
branch
from
1648a67 to
b58e39a
Compare
diegomura
force-pushed
the
dm/fix-conditional-rendering
branch
from
b58e39a to
dbc1b57
Compare
natterstefan
added a commit
to traveltechdeluxe/react-pdf
that referenced
this pull request
Dec 6, 2024
# By Diego Muracciole (31) and others # Via GitHub * upstream/master: (60 commits) feat: allow units for page size (diegomura#2773) chore: bump jay-peg chore: release packages (diegomura#2981) fix(textkit): make indentation only affect first line. (diegomura#2975) fix: conditional rendering (diegomura#2983) fix(reconciler): missing dependencies (diegomura#2980) chore: release packages (diegomura#2959) feat: rem border widths (diegomura#2960) fix: add scheduler dependency (diegomura#2958) chore: update README chore: release packages (diegomura#2953) feat: support rem units (diegomura#2955) feat: add image stress test example (diegomura#2954) feat: support multiple line-height units (diegomura#2952) chore: release packages (diegomura#2946) fix: note rendering (diegomura#2951) feat: accept commas between transformations (diegomura#2950) fix: document metadata setters (diegomura#2949) fix: stroke dash array computation (diegomura#2948) feat: remove cross-fetch (diegomura#2947) ... # Conflicts: # packages/renderer/index.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2978
Fixes #2982
Fixes #2973
Fixes #2957
Rollback to reconciler v23 for React 16, 17 and 18, which is what we historically used. I bumped it on the latest changes thinking it would be fine, but apparently I need a change I ignore. There's no reason why not going back to this. Has been working great for many years. People will start migrating to React 19 eventually and this will get deprecated over time