Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add scheduler dependency #2958

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: add scheduler dependency #2958

merged 2 commits into from
Nov 18, 2024

Conversation

diegomura
Copy link
Owner

Closes #2956

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9172675

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@react-pdf/reconciler Patch
@react-pdf/renderer Patch
next-14 Patch
next-15 Patch
@react-pdf/vite-example Patch
@react-pdf/e2e-node-cjs Patch
@react-pdf/e2e-node-esm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@diegomura diegomura merged commit f6e9e11 into master Nov 18, 2024
@diegomura diegomura deleted the dm/include-scheduler branch November 18, 2024 08:46
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
@AdrianMrn
Copy link

AdrianMrn commented Nov 18, 2024 •
edited
Loading

Hey @diegomura, it doesn't seem this fixed the error 🤔 not sure why, but even though I'm getting @react-pdf/[email protected], it doesn't seem like scheduler is included in my installed dependencies.

Maybe scheduler needs to be added under peerDependencies or dependencies instead of devDependencies? https://github.com/diegomura/react-pdf/blob/%40react-pdf/reconciler%401.1.2/packages/reconciler/package.json

Thanks a lot for this package btw, it's been super helpful to me :)

@mariuskalvo
Copy link

@AdrianMrn I had the same issue after upgrading to 4.1.4. Deleting and regenerating the package-lock.json file solved the problem for me. scheduler is no longer defined as a dependency for @react-pdf/renderer in lockfile 🙂

natterstefan added a commit to traveltechdeluxe/react-pdf that referenced this pull request Dec 6, 2024
@natterstefan
Merge remote-tracking branch 'upstream/master' into feat/form-annotation
2f0c551 
# By Diego Muracciole (31) and others
# Via GitHub
* upstream/master: (60 commits)
  feat: allow units for page size (diegomura#2773)
  chore: bump jay-peg
  chore: release packages (diegomura#2981)
  fix(textkit): make indentation only affect first line. (diegomura#2975)
  fix: conditional rendering (diegomura#2983)
  fix(reconciler): missing dependencies (diegomura#2980)
  chore: release packages (diegomura#2959)
  feat: rem border widths (diegomura#2960)
  fix: add scheduler dependency (diegomura#2958)
  chore: update README
  chore: release packages (diegomura#2953)
  feat: support rem units (diegomura#2955)
  feat: add image stress test example (diegomura#2954)
  feat: support multiple line-height units (diegomura#2952)
  chore: release packages (diegomura#2946)
  fix: note rendering (diegomura#2951)
  feat: accept commas between transformations (diegomura#2950)
  fix: document metadata setters (diegomura#2949)
  fix: stroke dash array computation (diegomura#2948)
  feat: remove cross-fetch (diegomura#2947)
  ...

# Conflicts:
#	packages/renderer/index.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@react-pdf/renderer 4.1.x requires scheduler
3 participants
@diegomura @AdrianMrn @mariuskalvo