Fix full page blocks #1541
Fix full page blocks #1541
Conversation
| ); | ||
| const setNodeHeight = node => { | ||
| const value = isPage(node) ? node.box.height : node.style.height; | ||
| return setHeight(value); |
There was a problem hiding this comment.
I like removing these ramda non-sense abstractions haha. I think there was a reason why for non-page nodes we were getting pre-computed box values... but cannot remember exactly. I'm afraid this might have side-effects. Anything you can think of?
There was a problem hiding this comment.
I think there was a reason why for non-page nodes we were getting pre-computed box values... but cannot remember exactly.
I don't know the reason too. I found commit message for this change, but it not informative bc0c3d1#diff-ec385a60982dcf369e67bbfe43eea67a5136efb7fd8c6ae3309f58208417b93d
I'm not an expert in yoga, but looks like it should be faster to calculate layout with predefined height values and i think that performance the only one reason. but it creates this weird inconvenient element size on the pages.
i debug and test this very well, and i can explain the bug flow if you interested in, and you can release it with beta tag for proper testing if you afraid this might have side-effects
There was a problem hiding this comment.
Thanks @jeetiss ! You're great.
i debug and test this very well
I think this is enough for me. I also tested it yesterday with no issues also. Agree it could've been a performance thing
fix #1509