fix: allow credentials option in Image #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ type SourceBuffer = Buffer | |||
|
|
|||
| type SourceDataBuffer = { data: Buffer; format: 'png' | 'jpg' } | |||
|
|
|||
| type SourceURLObject = { uri: string; method: HTTPMethod; body: any; headers: any } | |||
jeetiss
reviewed
Jan 31, 2023
|
Please merge this, thank you very much |
|
I don't see this merged, Is there any chance we could add the credentials flag? Or is there another workaround for fetching images with a cookie. Thank you! |
|
Can you merge this please what's the hold up! |
Co-authored-by: Dmitry Ivakhnenko <[email protected]>
🦋 Changeset detectedLatest commit: 7446c2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
diegomura
changed the title
|
Fantastic, can we get a new release too! 🙏 ❤️ |
|
This just saved my day! However, unfortunately I miss this part in the docs, is there a way to contribute to the docs? |
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change:
Added
credentialsoption which is required infetchin order to send cookies in cross-origin requests.src: mdn web docs
This PR also fixes the issue #1412