Add back functionality for bookmark props

[mgmolisani]

This restores functionality that seemed to have accidentally erased in a minor version update to converge the forked pdfkit vendor package. This resulted in all bookmarks being created in fit mode on the last page not respecting any of the props.

I additionally added some comments to roughly show where the custom logic of this file exists to give some signal that this should not be altered in future fork maintenance.

I tested this locally in a simple repro and observed both the raw output and the PDF in Adobe Reader were again properly linking to the page and respecting props.

There are no unit tests for the custom logic in this vendor package hence I did not add any new ones.

Resolves #2700

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8048716

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[typesafeui]

Nice! this probably closes #2682 too 🙌

[AgustinBilldin]

pls merge

[EvHaus]

Confirmed this fixes #2700 for me

[typesafeui]

@diegomura @wojtekmaj can we merge this?

[diegomura]

Thanks for pushing this. I really need to start using the base pdfkit thought 😞 Do you think you can try finding a way to fix this on react-pdf side?

[danomatic]

Polite bump. I've been pinned to an old version of @react-pdf/pdfkit for months to avoid the bugs this resolves.

[mgmolisani]

Thanks for pushing this. I really need to start using the base pdfkit thought 😞 Do you think you can try finding a way to fix this on react-pdf side?

I think since this is a regression from the original behavior in this lib and is blocking consumers from updating, its probably best to get this merged and then consider making changes to the vendor source package. I think blocking new features might be appropriate to steer the ship in that direction but fixing the regression should be priority # 1.