Wrap all math operations in parens #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
approved these changes
Mar 19, 2019
|
Lgtm with ci fixed |
Previously if you used local variables or parens in Rust to override the default order of operations, we would completely lose that information in the generated SQL. This would at best result in an unexpected value, but at worse would cause a query like `now + 2.minutes() * (some_int + 1)` to result in a runtime error complaining that there's no operator for `interval + integer` I intend to backport this to 1.4 Fixes #2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you used local variables or parens in Rust to override the
default order of operations, we would completely lose that information
in the generated SQL. This would at best result in an unexpected value,
but at worse would cause a query like
now + 2.minutes() * (some_int + 1)to result in a runtime error complaining that there's no operatorfor
interval + integerI intend to backport this to 1.4
Fixes #2017