Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usage of messaget in *_parse_options classes #4515

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Clean up usage of messaget in *_parse_options classes #4515

merged 4 commits into from
Apr 11, 2019

Conversation

romainbrenguier
Copy link
Member

Several classes inherits from messaget when they are not meant to be used as messaget.

  • Each commit message has a non-empty body, explaining why the change was made.
  • [na] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@romainbrenguier
janalyzer_parse_options is not a message
1e8f5b1 
In addition this class already inherits a messaget object of type messaget.
@romainbrenguier
goto_diff_parse_options is not a message
a6a06ae 
In addition the class already inherits a log field of type messaget.
@romainbrenguier
jdiff_parse_options is not a message
af22270 
In addition the class already inherits a log field of type messaget.
@romainbrenguier romainbrenguier force-pushed the clean-up/parse-options-messaget branch from 7439ce4 to 35dfdcf Compare April 11, 2019 10:07
@romainbrenguier
Remove redundant logger field
f9b461a 
There is already an inherited field log referencing the same thing.
@romainbrenguier romainbrenguier force-pushed the clean-up/parse-options-messaget branch from 35dfdcf to f9b461a Compare April 11, 2019 10:16
allredj
allredj reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f9b461a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107944891

@peterschrammel peterschrammel removed their assignment Apr 11, 2019
@romainbrenguier romainbrenguier merged commit 0ae5255 into diffblue:develop Apr 11, 2019
@romainbrenguier romainbrenguier deleted the clean-up/parse-options-messaget branch April 11, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

@tautschnig tautschnig tautschnig approved these changes

@smowton smowton smowton approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@danpoe danpoe Awaiting requested review from danpoe

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees

@chrisr-diffblue chrisr-diffblue

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romainbrenguier @smowton @tautschnig @peterschrammel @allredj @chrisr-diffblue