Fix pointer subtraction over integer constants #7398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
633875b replaced the simplification of `p - p` to zero, which previously was the only code to correctly evaluate to zero expressions like `(char *)n - (char *)n` for some integer `n` when using the SAT back-end: 5b8028a removed such support from the propositional back-end, as bounds-checking over the null object would have deemed each of the pointers out-of-bounds.
tautschnig
added
aws-high
Kani
Codecov ReportBase: 78.37% // Head: 78.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7398 +/- ##
===========================================
+ Coverage 78.37% 78.38% +0.01%
===========================================
Files 1647 1647
Lines 190328 190384 +56
===========================================
+ Hits 149172 149235 +63
+ Misses 41156 41149 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
peterschrammel
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
633875b replaced the simplification of
p - pto zero, which previously was the only code to correctly evaluate to zero expressions like(char *)n - (char *)nfor some integernwhen using the SAT back-end: 5b8028a removed such support from the propositional back-end, as bounds-checking over the null object would have deemed each of the pointers out-of-bounds.