Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove wavelength from loading metadata #123

Merged
merged 3 commits into from
Nov 1, 2024
Merged

remove wavelength from loading metadata #123

merged 3 commits into from
Nov 1, 2024

Conversation

yucongalicechen
Copy link
Collaborator

@yucongalicechen yucongalicechen commented Oct 31, 2024 •
edited
Loading

closes #121

Output before removal:
image2

Output after removal:
image1

@sbillinge ready for review

sbillinge
sbillinge approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. But I think it is non-intuitive that it would be this way, so I would add a comment on the METADATA_KEYS_TO_EXCLUDE that mentions that we exclude wavelength because of (why). this will help avoid confusion in the future likely

@yucongalicechen
Copy link
Collaborator Author

@sbillinge ready for review

@sbillinge sbillinge merged commit 79a32e7 into diffpy:main Nov 1, 2024
3 checks passed
@yucongalicechen yucongalicechen deleted the output-wavelength branch November 1, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillinge sbillinge sbillinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicated wavelength from output files
2 participants
@yucongalicechen @sbillinge