Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

XY-Grid Cell drops FlexboxPropTypes #79

Closed
joey-c opened this issue Aug 18, 2018 · 4 comments · Fixed by #80
Closed

XY-Grid Cell drops FlexboxPropTypes #79

joey-c opened this issue Aug 18, 2018 · 4 comments · Fixed by #80
Assignees
Labels

Comments

@joey-c
Copy link

joey-c commented Aug 18, 2018

Cell accepts both GeneralPropTypes and FlexboxPropTypes but only calls generalClassNames(props). It does not call flexboxClassNames(props).

What did you do?

Pass alignX='center' or centerAlign to a Cell

What did you expect to happen?

Contents of cell to be centered

What actually happened?

Contents were not centered. Cell generated did not have any other classes.

What version of this module are you using?

0.9.3. Foundation-sites: 0.9.5.

Please include code that reproduces the issue. The best reproductions are self-contained scripts with minimal dependencies.

<Cell alignX='center'>alignX</Cell>
<Cell centerAlign>centerAlign</Cell>
@crisu83
Copy link
Contributor

crisu83 commented Aug 19, 2018

@joey-c Thanks for reporting this issue. Would you mind creating a PR to fix this issue?

@crisu83 crisu83 added the bug label Aug 19, 2018
crisu83 added a commit that referenced this issue Aug 19, 2018
@crisu83 crisu83 self-assigned this Aug 19, 2018
@crisu83
Copy link
Contributor

crisu83 commented Aug 19, 2018

Nevermind, I already took care of it myself. 😄

@crisu83
Copy link
Contributor

crisu83 commented Aug 20, 2018

Hello @joey-c, install the latest release (0.9.6) and it should fix your issue. Let me know if it works.

@joey-c
Copy link
Author

joey-c commented Aug 20, 2018

Thanks for the speedy fix – I've tried 0.9.6 and the classes get applied as expected!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants