This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Fix ResponsiveNavigation resize handler leak #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for this. |
crisu83
pushed a commit
that referenced
this pull request
Jun 21, 2017
* Fix ResponsiveNavigation resize event leak * Use bind instead of class properties
Merged
crisu83
added a commit
that referenced
this pull request
Jun 21, 2017
* Update nodejs versions in Travis configuration (to latest, 6, 5 and 4) * Fix ResponsiveNavigation resize handler leak (#27) * Fix ResponsiveNavigation resize event leak * Use bind instead of class properties * Add accordion component (#30) * Add accordion component * Add missing isActive prop on AccordionContent * Add tests for isActive prop on AccordionContent * Add yarn.lock * Change to use prop-types library * Fix warning in progress bar test * Fix linting errors * Add precommit hook
Closed
crisu83
added a commit
that referenced
this pull request
Jul 5, 2017
* Update nodejs versions in Travis configuration (to latest, 6, 5 and 4) * Fix ResponsiveNavigation resize handler leak (#27) * Fix ResponsiveNavigation resize event leak * Use bind instead of class properties * Add accordion component (#30) * Add accordion component * Add missing isActive prop on AccordionContent * Add tests for isActive prop on AccordionContent * Add yarn.lock * Change to use prop-types library * Fix warning in progress bar test * Fix linting errors * Add precommit hook * Bump version * Update Travis CI badge link * Convert remaining PropTypes imports to use prop-types library (#34) * Bump version * Bump version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.