Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change triggers AllInDar export method #20482

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

samuel-williams-da
Copy link
Contributor

@samuel-williams-da samuel-williams-da commented Dec 16, 2024

See #20481
Explicit exports can't handle dropping this export as it was part of the export of another data type, and we don't deep search the exports.
This quick fix works by moving the pattern to a top level export, so it is pruned correctly.

@samuel-williams-da samuel-williams-da enabled auto-merge (squash) December 16, 2024 11:18
@samuel-williams-da samuel-williams-da force-pushed the sw/drop-triggers-all-in-dar branch from 754dc6f to 52ef54f Compare December 16, 2024 12:27
@samuel-williams-da samuel-williams-da changed the title Drop triggers AllInDar Change triggers AllInDar export method Dec 16, 2024
@samuel-williams-da samuel-williams-da merged commit c832cb4 into main-2.x Dec 16, 2024
18 checks passed
@samuel-williams-da samuel-williams-da deleted the sw/drop-triggers-all-in-dar branch December 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants