Wrong characters for Aztec decoder in Decoder.MIXED_TABLE
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderpopko
changed the title
Decoder.MIXED_TABLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in zxing-js#607 decoding Aztec codes in some cases gives wrong results, i.e.,
'\x01'/'\x02'/'\x03'/'\x04'/'\x05'/'\x06'/'\x07'/'\x0b'/'\x1b'/'\x1c'/'\x1d'/'\x1e'/'\x1f'/'\x7f'get decoded to'\\1'/'\\2'/'\\3'/'\\4'/'\\5'/'\\6'/'\\7'/'\\13'/'\\33'/'\\34'/'\\35'/'\\36'/'\\37'/'\\177'.By applying this pull request the above mentioned characters should get correctly decoded.
The current array entries were probably adopted from the Java version of this library, where one may specify characters by their octal code points using a
"\[0-9]"notation. Thus, e.g.,"\13"in Java equals, e.g.,String.fromCharCode(0o13)or'\x0b'in JavaScript.