IGAPP-602: Setup basic ts project web #267

sarahsporck · 2021-04-23T13:28:28Z

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

I already copied the www package so the fonts mentioned in index.ejs could be found without any issues
I could not import the build config yet, as the files do not compile on this branch. I think it makes sense to first do IGAPP-597 before adding them to the webpack.config.js

maxammann

Before I start reviewing this, should we base this on main?

sarahsporck · 2021-04-26T13:24:16Z

Before I start reviewing this, should we base this on main?

Hmm. Not Sure about that as it seems the build config files already have a *.ts ending, but don't compile. This would definitely create issue with the ci. Or did you mean changing the base branch to Main without any change from web-ts-init?

steffenkleinle · 2021-04-26T15:34:10Z

I think the latter, otherwise reviewing is quite hard if you don't remember what we were doing on the conference already here.

ztefanie · 2021-04-28T07:52:19Z

I think the latter, otherwise reviewing is quite hard if you don't remember what we were doing on the conference already here.

Should web-ts-init also be merged? Should we open a PR for it?

steffenkleinle · 2021-04-28T08:02:30Z

I'd just review it together as web-ts-init is really WIP and not finished (or rather: finished by this branch/PR). So I think we should just review and merge it together in this PR.

…g.ts

sarahsporck · 2021-04-28T14:06:35Z

Some files have been autogenerated by create-react-app (README.md, App.css, ...) I guess. Should I remove them or keep them for now?

Furthermore I recommend checking this branch out and clicking around. A lot of the changes still encompass the www folder

sarahsporck · 2021-04-28T14:08:58Z

web-ts/package.json

+    "npm": ">=3.8"
+  },
+  "scripts": {
+    "start": "cross-env TS_NODE_PROJECT=\"tools/tsconfig.webpack.json\" webpack-dev-server --config tools/webpack.config.ts --progress --env.config_name=integreat-test-cms --env.dev_server",


cross-env TS_NODE_PROJECT=\"tools/tsconfig.webpack.json\" most ugly workaround for webpack.config.ts
Read more here in the webpack-docu or this webpack-cli issue

web-ts/package.json

sarahsporck · 2021-04-28T14:11:02Z

web-ts/tools/webpack.config.ts

@@ -0,0 +1,295 @@
+import {Configuration, DefinePlugin, LoaderOptionsPlugin, optimize} from "webpack";


Yay typescript 🎉

Yay, can we have prettier/linting as well? 😁 Or is this something we should rather do in a separate PR?

Separate PR I think. We also do not have it in the flow project.

Why would we want it in the flow project?

sarahsporck · 2021-04-28T14:14:24Z

web-ts/tsconfig.json

@@ -0,0 +1,27 @@
+{
+  "compilerOptions": {
+    "target": "ES2020",


This one we could discuss. On IGAPP-web-ts-init it was set to esnext, which is at least in my opinion not a stable form of release. In our current web project we use es6(=es2015) syntax.

I think ES2020 is fine for now 👍

I don't think that this config will support IE11, but I'd just leave this and see some time later what to choose here.

I see what you mean here. Probably we will have to stay with es6, as previously. Check out Caniuse.com.

steffenkleinle · 2021-04-28T14:52:57Z

Some files have been autogenerated by create-react-app (README.md, App.css, ...) I guess. Should I remove them or keep them for now?

Furthermore I recommend checking this branch out and clicking around. A lot of the changes still encompass the www folder

I think you could remove those files, less to review for us and less changes at a later point.

steffenkleinle · 2021-04-28T14:53:15Z

🎉 🎉

steffenkleinle

Seems to work 👍 Highway to typescript 🚀

web-ts/src/index.ejs

web-ts/package.json

web-ts/tools/tsconfig.webpack.json

web-ts/README.md

web-ts/package.json

web-ts/src/index.css

web-ts/src/index.ejs

web-ts/src/reportWebVitals.ts

maxammann · 2021-05-02T13:51:11Z

web-ts/tools/webpack.config.ts

@@ -0,0 +1,295 @@
+import {Configuration, DefinePlugin, LoaderOptionsPlugin, optimize} from "webpack";


Separate PR I think. We also do not have it in the flow project.

web-ts/tools/webpack.config.ts

web-ts/tools/tsconfig.webpack.json

maxammann · 2021-05-02T13:53:07Z

web-ts/tsconfig.json

@@ -0,0 +1,27 @@
+{
+  "compilerOptions": {
+    "target": "ES2020",


I don't think that this config will support IE11, but I'd just leave this and see some time later what to choose here.

web-ts/www/humans.txt

sarahsporck requested review from a-kud, steffenkleinle, maxammann, NKlug, michael-markl, SimonVortkamp, ztefanie and Znippet as code owners April 23, 2021 13:28

maxammann requested changes Apr 23, 2021

View reviewed changes

sarahsporck added 2 commits April 28, 2021 11:26

IGAPP-602: Changes from web-ts from IGAPP-web-ts-init + webpcak.confi…

2f4088d

…g.ts

IGAPP-602: basic eslint, tsconfig using es11

1601880

sarahsporck force-pushed the IGAPP-602-setup-basic-ts-project-web branch from a59ef30 to 1601880 Compare April 28, 2021 14:04

sarahsporck changed the base branch from IGAPP-web-ts-init to main April 28, 2021 14:05

sarahsporck commented Apr 28, 2021

View reviewed changes

web-ts/package.json Outdated Show resolved Hide resolved

sarahsporck commented Apr 28, 2021

View reviewed changes

steffenkleinle approved these changes Apr 30, 2021

View reviewed changes

web-ts/src/index.ejs Show resolved Hide resolved

web-ts/package.json Outdated Show resolved Hide resolved

web-ts/tools/tsconfig.webpack.json Outdated Show resolved Hide resolved

maxammann approved these changes May 2, 2021

View reviewed changes

sarahsporck added 4 commits May 3, 2021 14:52

IGAPP-602: remove unused files

3edbd09

IGAPP-602: fix compiler target for webpack tsconfig

8719a1d

IGAPP-602: add todo to index.ejs

3fad11a

IGAPP-602: moved types to dev dependencies, removed README.md

363e0d4

sarahsporck added 5 commits May 3, 2021 15:10

IGAPP-602: simplify run scripts in package.json

220f916

IGAPP-602: update humans.txt

fbabb18

IGAPP-602: add todo to read code

8f552aa

Merge branch 'main' into IGAPP-602-setup-basic-ts-project-web

f239dac

Merge branch 'main' into IGAPP-602-setup-basic-ts-project-web

f0aa39d

sarahsporck enabled auto-merge May 4, 2021 09:44

sarahsporck merged commit fa24a0e into main May 4, 2021

sarahsporck deleted the IGAPP-602-setup-basic-ts-project-web branch May 4, 2021 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGAPP-602: Setup basic ts project web #267

IGAPP-602: Setup basic ts project web #267

sarahsporck commented Apr 23, 2021

maxammann left a comment

sarahsporck commented Apr 26, 2021

steffenkleinle commented Apr 26, 2021

ztefanie commented Apr 28, 2021

steffenkleinle commented Apr 28, 2021

sarahsporck commented Apr 28, 2021 •

edited

Loading

sarahsporck Apr 28, 2021

sarahsporck Apr 28, 2021

steffenkleinle Apr 28, 2021

maxammann May 2, 2021

steffenkleinle May 3, 2021

sarahsporck Apr 28, 2021

steffenkleinle Apr 28, 2021

maxammann May 2, 2021

sarahsporck May 3, 2021

steffenkleinle commented Apr 28, 2021

steffenkleinle commented Apr 28, 2021

steffenkleinle left a comment

maxammann May 2, 2021

maxammann May 2, 2021

		@@ -0,0 +1,295 @@
		import {Configuration, DefinePlugin, LoaderOptionsPlugin, optimize} from "webpack";

IGAPP-602: Setup basic ts project web #267

IGAPP-602: Setup basic ts project web #267

Conversation

sarahsporck commented Apr 23, 2021

maxammann left a comment

Choose a reason for hiding this comment

sarahsporck commented Apr 26, 2021

steffenkleinle commented Apr 26, 2021

ztefanie commented Apr 28, 2021

steffenkleinle commented Apr 28, 2021

sarahsporck commented Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steffenkleinle commented Apr 28, 2021

steffenkleinle commented Apr 28, 2021

steffenkleinle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarahsporck commented Apr 28, 2021 •

edited

Loading