Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "LsqFit" to "0.11" #31

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the LsqFit package from 0.6, 0.7, 0.8, 0.9, 0.10 to 0.6, 0.7, 0.8, 0.9, 0.10, 0.11.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #31 into master will increase coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   93.45%   94.64%   +1.19%     
==========================================
  Files           4        4              
  Lines         168      168              
==========================================
+ Hits          157      159       +2     
+ Misses         11        9       -2     
Impacted Files Coverage Δ
src/embeddings.jl 94.44% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bae69d...8830aeb. Read the comment docs.

@rasmushenningsson
Copy link

Could you merge this and release a new patch version?
The CI failures seem unrelated.

@dillondaudert dillondaudert merged commit 5594f22 into master Aug 20, 2020
@rasmushenningsson
Copy link

Thanks!

kragol pushed a commit to kragol/UMAP.jl that referenced this pull request Sep 15, 2020
…ew_version/2020-06-23-22-01-58-485-3008906204

CompatHelper: bump compat for "LsqFit" to "0.11"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants