Added check that template does not use both requirejs and webpack #35449
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
commented
Nov 27, 2024
| @@ -726,13 +726,20 @@ class RequireJSMainNode(template.Node): | |||
| def __init__(self, name, value): | |||
| self.name = name | |||
| self.value = value | |||
| self.origin = None | |||
There was a problem hiding this comment.
I needed this to get the exception to display in my browser locally. Without it, an error about origin not being found supersedes the original exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This would have prevented https://dimagi.atlassian.net/browse/SAAS-16313, which was caused by a template using requirejs while inheriting from a template that used webpack.
Safety Assurance
Safety story
Adds a check for an error condition that breaks pages.
Automated test coverage
In PR
QA Plan
Not requesting QA
Rollback instructions
Labels & Review