Fixed MarkdownSanitizer altering URL symbols #2501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Suggested by EclipsedSolari in issue discord-jda#2378 -The algorithm implemented searches and replaces all URLs by a placeholder, and replaces them back after the majority of the compute method finishes. -Also added a test method in the MarkdownTest class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: #2378
Description
Previously, MarkdownSanitizer sanitizes symbols used in URLs, despite Discord ignoring them and not treating them as markdowns.
The algorithm implemented searches and replaces all URLs by a placeholder, and replaces them back after the majority of the MarkdownSanitizer#compute method finishes.
A dedicated method had also been added to the MarkdownTest class to efficiently test this algorithm.