Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Breaking Changes in v10 #806

Closed
5 tasks done
SQKo opened this issue May 23, 2022 · 8 comments
Closed
5 tasks done

TODO: Breaking Changes in v10 #806

SQKo opened this issue May 23, 2022 · 8 comments
Assignees
Milestone

Comments

@SQKo
Copy link
Member

SQKo commented May 23, 2022

Since the deprecation of bulk endpoints for the BOT in the Permissions v2, the application command permissions "overwrite" structure is no longer relevant to be a repository, also the naming should be just "command Permissions", with "Permission" parts in it.

At the moment the repository only contains a single Permission part

  • Rename Remove "Overwrite" to "CommandPermissions"
  • Change type from Repository to Part
  • Remove disabled endpoints that only work with bearer oauth2 token

I think this can be more to swapping the Repository->Part with Part->Repository, I'm not sure yet we'll see later

Since this is a breaking change, I'm noting this for v8 milestone.

EDIT:

@SQKo SQKo added this to the 8.0 milestone May 23, 2022
@SQKo
Copy link
Member Author

SQKo commented Jun 5, 2022

  • The guild feature SEVEN_DAY_THREAD_ARCHIVE and THREE_DAY_THREAD_ARCHIVE should be also removed in next major version, deprecate in next minor version because its no longer part of boost feature.

#889

@SQKo SQKo changed the title TODO: Change "Commands Overwrites", Require GMP in v8 TODO: Breaking Changes in v8 Jun 5, 2022
@SQKo
Copy link
Member Author

SQKo commented Jun 29, 2022

The $message->channel_mentions behavior should be changed that is actually purposed for Channels object as seen in followed News Channel, not actual #channel mention in the message.

Edit: I was wrong about this the code seems already doing correctly (remove todo later)

@SQKo
Copy link
Member Author

SQKo commented Jul 13, 2022

  • Reaction::getUsers() no longer have 'before' options, providing this to the API has no effect. Thus the option should be removed.

See https://discord.com/developers/docs/resources/channel#get-reactions

#886

@SQKo
Copy link
Member Author

SQKo commented Jul 13, 2022

  • The guild feature COMMERCE has been removed along with store channels

discord/discord-api-docs#5180

#787

double check the lists later: https://discord.com/developers/docs/resources/guild#guild-object-guild-features

@SQKo
Copy link
Member Author

SQKo commented Jul 22, 2022

  • Change ban parameter delete_message_days to delete_message_seconds

#867

@key2peace key2peace changed the title TODO: Breaking Changes in v8 TODO: Breaking Changes in v10 Aug 11, 2022
@SQKo
Copy link
Member Author

SQKo commented Aug 24, 2022

  • Stage Instance Repository should be part of Channel, not Guild, even though the events filled from guild, this is same how Discord fills threads from Guild Create event.

This BC will require you to change:

$guild->stage_instances

to:

$channel->stage_instances

Where $channel must be individually get() from $guild->channels first.

#895

@SQKo
Copy link
Member Author

SQKo commented Aug 24, 2022

  • We also agreed to remove deprecate $scriptData from Part, Not sure if there are many people using it, please comment here if you do.

This is due to the change to caching system and Part::scriptData will be likely Garbage Collected. The solution is to reference the Part object instead.

$guild->scriptData = $myData;

to:

$myData->guild = $guild;

or if $myData is an associative array

$myData['guild'] = $guild;

where $myData is either static or global variable scope, and $guild is an instance of Part

@SQKo
Copy link
Member Author

SQKo commented Aug 31, 2022

  • Also double check the @todo list before release since they are also BC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant