Add User avatar_decoration #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key2peace
previously approved these changes
Dec 13, 2022
|
This only returned in new clients at the moment, not for bots (field exists but always null). So waiting for release. |
key2peace
previously approved these changes
Dec 15, 2022
Exanlv
reviewed
Jan 23, 2023
| if (! in_array(strtolower($format), $allowed)) { | ||
| $format = 'png'; | ||
| } | ||
| } elseif (strpos($this->attributes['avatar_decoration'], 'a_') === 0) { |
There was a problem hiding this comment.
Looks like the default is png whether its animated or not. Wouldn't it make more sense to change the input to string $format = 'png' rather than have these checks?
key2peace
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discord/discord-api-docs#5723