Document banner & banner color #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps you'd want to also document the image formatting reference: |
Done. |
advaith1
reviewed
Jul 14, 2021
advaith1
reviewed
Jul 14, 2021
Co-authored-by: Advaith <[email protected]>
advaith1
approved these changes
Jul 14, 2021
|
q for staff: is there a reason banner_color is sent as a string, and not as an integer? embed colors and role colors are sent as integers, so this is inconsistent |
|
re ^, they'll change it to an integer
|
apacheli
reviewed
Jul 17, 2021
Closed
5 tasks
|
This is still an experiment and therefore the API is subject to change, will revisit once the feature is finalized |
Co-authored-by: Florian Spieß <[email protected]>
|
|
|
It looks like both are still being sent should both be documented? or have
|
l7ssha
added a commit
to nyxx-discord/nyxx
that referenced
this pull request
Jul 19, 2021
ghost
mentioned this pull request
Nihlus
added a commit
to Remora/Remora.Discord
that referenced
this pull request
Aug 18, 2021
ghost
mentioned this pull request
7596ff
pushed a commit
to twilight-rs/twilight
that referenced
this pull request
Sep 17, 2021
Add the new `accent_color` and `banner` fields. `accent_color` is an integer representation of the RGB color while `banner` is a hash of the user's banner image. This is documented in the API docs: <discord/discord-api-docs#3448> Closes #1126.
MaxOhn
pushed a commit
to MaxOhn/twilight
that referenced
this pull request
Oct 7, 2021
Add the new `accent_color` and `banner` fields. `accent_color` is an integer representation of the RGB color while `banner` is a hash of the user's banner image. This is documented in the API docs: <discord/discord-api-docs#3448> Closes twilight-rs#1126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user's banner and banner color appear to only be returned on the canary API currently, and only a small percentage of users can set their banner color.