Added CSP executeScript fallback #80
Conversation
src/content/init.js
Outdated
| }).json; | ||
| const json = await data; | ||
|
|
||
| window.__discoveryPreloader = preloader; // eslint-disable-line no-underscore-dangle |
There was a problem hiding this comment.
I suppose there is no need to expose preloader, since we just do preloader.el.remove() we can do it right before initDiscovery check
There was a problem hiding this comment.
We have to wait for the discovery initialization. In the case of the fallback, this happens in a separate context, so I pass it through global. Tested it on large JSONs
There was a problem hiding this comment.
Well, preloader is needed while data is loading. Is it actual when data is loaded?
There was a problem hiding this comment.
Sure. Otherwise the loading will stop at data parsing step and you will see the Discovery immediately (skipping the init ui, prepare etc steps)
src/content/init.js
Outdated
| if (typeof initDiscovery !== 'function') { | ||
| await chrome.runtime.sendMessage({ type: 'initDiscovery' }); | ||
| } else { | ||
| await initDiscovery(...window.__discoveryOptions); |
There was a problem hiding this comment.
Suggestion:
const discoveryOptions = {...};
if (typeof initDiscovery !== 'function') {
window.__discoveryOptions = discoveryOptions;
chrome.runtime.sendMessage({ type: 'initDiscovery' });
} else {
initDiscovery(...discoveryOptions);
}
src/content/init.js
Outdated
|
|
||
| preloader.el.remove(); | ||
| const { initDiscovery } = await import(chrome.runtime.getURL('discovery-esm.js')); |
There was a problem hiding this comment.
I believe you should try revert to Promise.all()
| preloader.el.remove(); | ||
| const { initDiscovery } = await import(chrome.runtime.getURL('discovery-esm.js')); | ||
|
|
||
| if (typeof initDiscovery !== 'function') { |
There was a problem hiding this comment.
Would be nice to add a comment what is going on here
Fixes #78