Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test requirements after removing the patching pattern #303

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Dec 29, 2022

Description

After merging #300 the test requirements need to be fixed against the django-cms/develop-4 branch (which now also contains the changes needed for #300)

Additionally we can now use the latest released djangocms-text-ckeditor since as of 5.1.2 it supports django CMS 4

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #303 (8567add) into master (4567b34) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files          67       67           
  Lines        2196     2196           
  Branches      293      293           
=======================================
  Hits         1971     1971           
  Misses        170      170           
  Partials       55       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun fsbraun merged commit f13e299 into master Dec 29, 2022
@marksweb marksweb deleted the fix/test-requirements branch March 17, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants