Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translation inconsistencies #313

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jan 23, 2023

Description

This PR standardizes the short name of a Version object to allow for consistent translation especially in the toolbar menu.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • [x ] I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #313 (b1fd19b) into master (9e1183a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   89.87%   89.88%           
=======================================
  Files          68       68           
  Lines        2242     2244    +2     
  Branches      299      299           
=======================================
+ Hits         2015     2017    +2     
  Misses        172      172           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/cms_toolbars.py 95.70% <100.00%> (ø)
djangocms_versioning/models.py 94.91% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun fsbraun requested a review from vinitkumar January 23, 2023 10:04
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 33a28c9 into django-cms:master Jan 23, 2023
@fsbraun fsbraun deleted the fix/translation_inconsistencies branch January 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants