Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: burger menu to also work with new core icons #323

Merged
merged 7 commits into from
Apr 25, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Mar 15, 2023

Description

This PR fixes the burger menu to

  1. work with icons provided by the core
  2. variable width content
  3. Only display if there are elements in the burger menu
  4. CMS style (same as e.g., state indicator drop down or page tree dropdowns)

Example djangocms-admin-style

image

Example bare django admin

image

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from Aiky30 March 15, 2023 10:03
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #323 (5ed516c) into master (1e8a48c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          68       68           
  Lines        2324     2324           
  Branches      314      314           
=======================================
  Hits         2104     2104           
  Misses        165      165           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/admin.py 89.13% <ø> (ø)
djangocms_versioning/indicators.py 91.07% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun fsbraun requested a review from marksweb March 28, 2023 20:35
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsbraun fsbraun merged commit abc8ea7 into django-cms:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants