-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PageContent extension's copy_relations
method not called
#344
fix: PageContent extension's copy_relations
method not called
#344
Conversation
Co-authored-by: Jacob Rief <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 90.90% 90.86% -0.04%
==========================================
Files 72 72
Lines 2530 2530
Branches 356 356
==========================================
- Hits 2300 2299 -1
Misses 170 170
- Partials 60 61 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not ran it, but this makes sense 👍
This needs an update as there's conflicts with the main branch. |
Description
This PR fixes #342 and is based on #343.
CMS extensions have a
copy
method. It also takes care of callingcopy_relations
.djangocms-versioning needs not recreate this method where it can miss the call of
copy_relations
but instead can use the original method instead.Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.