Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PageContent extension's copy_relations method not called #344

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 9, 2023

Description

This PR fixes #342 and is based on #343.

CMS extensions have a copy method. It also takes care of calling copy_relations.

djangocms-versioning needs not recreate this method where it can miss the call of copy_relations but instead can use the original method instead.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested review from marksweb, Aiky30 and jrief July 9, 2023 06:57
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.04% ⚠️

Comparison is base (6ac73e8) 90.90% compared to head (671fc1c) 90.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   90.90%   90.86%   -0.04%     
==========================================
  Files          72       72              
  Lines        2530     2530              
  Branches      356      356              
==========================================
- Hits         2300     2299       -1     
  Misses        170      170              
- Partials       60       61       +1     
Files Changed Coverage Δ
djangocms_versioning/cms_config.py 80.36% <66.66%> (-0.46%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not ran it, but this makes sense 👍

@marksweb
Copy link
Member

This needs an update as there's conflicts with the main branch.

@fsbraun fsbraun merged commit 8e045dd into django-cms:master Sep 22, 2023
@fsbraun fsbraun mentioned this pull request Sep 27, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageContentExtension should offer hook copy_relations
2 participants