Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #349

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Fix tests #349

merged 3 commits into from
Sep 11, 2023

Conversation

FinalAngel
Copy link
Member

Description

Related resources

This fixes the ruff tests not passing

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Member

fsbraun commented Sep 11, 2023

@FinalAngel I believe there needs to hyphens instead of spaces here for tests to pass:

new_title = "new slug here"

(I just updated with those changes in the main branch.)

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ad24c93) 90.93% compared to head (0b9b470) 90.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          72       72           
  Lines        2536     2536           
  Branches      357      357           
=======================================
  Hits         2306     2306           
  Misses        170      170           
  Partials       60       60           
Files Changed Coverage Δ
djangocms_versioning/cms_config.py 80.82% <ø> (ø)
djangocms_versioning/helpers.py 91.39% <ø> (ø)
djangocms_versioning/admin.py 90.70% <100.00%> (ø)
djangocms_versioning/cms_toolbars.py 96.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FinalAngel for fixing the linting.

@fsbraun fsbraun merged commit ca50367 into master Sep 11, 2023
79 checks passed
@FinalAngel FinalAngel deleted the fix-tests branch September 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants