Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update templates for better styling w/o djangocms-admin-style #352

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 13, 2023

Description

This PR adds the .submit-row <div> used in Django admin for more consistent styling.

It also removes an unused left-over helper function (legacy of pre-2.0):

  • djangocms_verisoning.helpers.remove_published_where(qs) used to patch a queryset removing the resulting SQL WHERE statement which restricts the queryset to include published versions only.
  • It is not used in the codebase any more. Usage in djangocms-alias has been removed a while ago.
  • The official pattern is to use the admin_manager of a versioned model which as the name indicates should only be used in the admin.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21% 🎉

Comparison is base (5944cff) 90.69% compared to head (3204c1b) 90.90%.

❗ Current head 3204c1b differs from pull request most recent head bf1c6bf. Consider uploading reports for the commit bf1c6bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   90.69%   90.90%   +0.21%     
==========================================
  Files          72       72              
  Lines        2536     2530       -6     
  Branches      357      356       -1     
==========================================
  Hits         2300     2300              
+ Misses        175      170       -5     
+ Partials       61       60       -1     
Files Changed Coverage Δ
djangocms_versioning/helpers.py 91.11% <100.00%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from marksweb September 13, 2023 07:48
@fsbraun fsbraun merged commit 6ac73e8 into django-cms:master Sep 22, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants